-
Notifications
You must be signed in to change notification settings - Fork 75
feat: add asyncio.Lock to prevent concurrent refreshes #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
looks like Python 3.9 is not having it 🤡 |
Not sure about the root cause but I am not investing more time for a 3.9-specific workaround given its reaching the end of support in October, so until then this PR can wait I hope. |
Yeah, I suspected so. I wouldn't bother either |
Seems like pydantic-core is no longer supporting 3.9, so I think we can remove support too. So if you’d like to resurrect this PR with removal of 3.9 support, I’d be happy to merge |
I removed Python 3.9 and added 3.13 for tests, and made the 3.12 the "default". Due to a pytest plugin error in CI for 3.13 I went ahead and upgraded all dev dependencies. Now I have two issues I'm not sure how to solve and where I need your input @JonasKs :
|
I'll try to look into this further this weekend, but it seems like the tests only fails when all tests are run, not when just that test is run. I suspect something is leaking between tests |
implementation of #233