Skip to content

feat: add asyncio.Lock to prevent concurrent refreshes #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

davidhuser
Copy link
Contributor

implementation of #233

@davidhuser
Copy link
Contributor Author

looks like Python 3.9 is not having it 🤡

@davidhuser
Copy link
Contributor Author

Not sure about the root cause but I am not investing more time for a 3.9-specific workaround given its reaching the end of support in October, so until then this PR can wait I hope.

@JonasKs
Copy link
Member

JonasKs commented Apr 23, 2025

Yeah, I suspected so. I wouldn't bother either☺️
Let's keep it open and merge with 3.9 deprecation.

@JonasKs
Copy link
Member

JonasKs commented Jun 5, 2025

Seems like pydantic-core is no longer supporting 3.9, so I think we can remove support too. So if you’d like to resurrect this PR with removal of 3.9 support, I’d be happy to merge ☺️

@davidhuser
Copy link
Contributor Author

davidhuser commented Jun 10, 2025

I removed Python 3.9 and added 3.13 for tests, and made the 3.12 the "default". Due to a pytest plugin error in CI for 3.13 I went ahead and upgraded all dev dependencies.

Now I have two issues I'm not sure how to solve and where I need your input @JonasKs :

  1. linting fails due to fix end of files but it passes with the same config on my local machine.
  2. this test fails with the wrong reponse ("no signing keys found"), but I don't understand the logic or why that test passed previously. The test run also notices that it actually was never mocked. And the function name is slightly confusing (since it's about error not old config).

@JonasKs
Copy link
Member

JonasKs commented Jun 17, 2025

I'll try to look into this further this weekend, but it seems like the tests only fails when all tests are run, not when just that test is run. I suspect something is leaking between tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants