[uss_qualifier] oir implicit sub scenario: oir with no subscription mutated to get implicit sub #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
oir-implicit-expand-8
branch
from
51a6844 to
bec9cd8
Compare
Shastick
force-pushed
the
oir-implicit-expand-8
branch
from
bec9cd8 to
3d1e56f
Compare
mickmis
reviewed
Jun 5, 2025
| @@ -322,7 +322,38 @@ it is in violation of **[astm.f3548.v21.DSS0005,1](../../../../requirements/astm | |||
|
|
|||
| #### 🛑 OIR is now attached to an implicit subscription check | |||
|
|
|||
| If the DSS under test fails to attach the OIR to an implicit subscription (which may either already exist or be newly created) when it is requested to do so, | |||
| If the DSS under test fails to attach the OIR to an implicit subscription (which may either already exist or be newly created) when it is requested to do, | |||
There was a problem hiding this comment.
Suggested change
| If the DSS under test fails to attach the OIR to an implicit subscription (which may either already exist or be newly created) when it is requested to do, | |
| If the DSS under test fails to attach the OIR to an implicit subscription (which may either already exist or be newly created) when it is requested to do so, |
monitoring/uss_qualifier/scenarios/astm/utm/dss/oir_implicit_sub_handling.md
Show resolved
Hide resolved
| @@ -134,7 +134,7 @@ or **[astm.f3548.v21.DSS0005,5](../../../../requirements/astm/f3548/v21.md)**. | |||
|
|
|||
| #### [No implicit subscription was attached](./fragments/oir/oir_has_no_subscription.md) | |||
|
|
|||
| ### [Cleanup After Test Case test step](./cleanup_after_testcase_oir_subs.md) | |||
| ### [Cleanup After Test Case test step](./fragments/oir/crud/delete_query.md) | |||
There was a problem hiding this comment.
Why this change? Here and below.
Shouldn't the cleanup of subscriptions actually be implemented?
Shastick
force-pushed
the
oir-implicit-expand-8
branch
from
3d1e56f to
3d66900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the last scenario in interuss/dss#1088
The PR is stacked on top of #1036, please only consider the two last commit.