need to get the chrome tracing lock when flushing the trace file #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the chrome tracing lock is acquired during file flushes to prevent corruption when multiple threads are involved.
- Acquires the chrome tracing lock at the start of flush() even if the record buffer is empty.
- Removes the redundant lock acquisition previously present within the if block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
If one thread is writing to the chrome trace file while another thread flushes the file then the file may be corrupted. So, grab the chrome tracing lock when flushing the file, even if there are no chrome tracing records.
Testing Done
Tested with a heavily multi-threaded application that very occasionally generated a corrupted file before this change, but never after this change.