add basic support for SVM and USM capture and replay #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still limitations, specifically when setting a pointer to the middle of an SVM or USM allocation as a kernel argument, or when accessing SVM or USM indirectly. Basic cases should be working, though, that set a pointer to the base of an SVM or USM allocation as a kernel argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds basic capture and replay support for SVM and USM allocations. There are still limitations, specifically when setting a pointer to the middle of an SVM or USM allocation as a kernel argument, or when accessing SVM or USM indirectly. Basic cases should be working, though, that set a pointer to the base of an SVM or USM allocation as a kernel argument.
Testing Done
Tested with basic SYCL book samples that use USM.