Skip to content

[CI] Re-enable zstd in CI #20381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[CI] Re-enable zstd in CI #20381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
248e957
Re-enable zstd in CI
uditagarwal97 Oct 16, 2025
6881d6f
Disable Compression tests on native cpu and preview mode
uditagarwal97 Oct 19, 2025
e585785
XFAIL more tests
uditagarwal97 Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coverity.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
cd $GITHUB_WORKSPACE/build
python3 $GITHUB_WORKSPACE/src/buildbot/configure.py -w $GITHUB_WORKSPACE \
-s $GITHUB_WORKSPACE/src -o $GITHUB_WORKSPACE/build -t Release \
--ci-defaults --hip --cuda \
--ci-defaults --use-zstd --hip --cuda \
Copy link
Contributor

@KornevNikita KornevNikita Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to move this to --ci-defaults? or something like:

    if args.use_zstd or args.ci_defaults::
        llvm_enable_zstd = "FORCE_ON"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--ci-defaults is used in sycl-web and the runners used in sycl-web testing don't have zstd installed. I did try moving it to --ci-defaults in the past, but that ended up breaking pulldown testing. For reference: #15840

-DNATIVECPU_USE_OCK=Off

- name: Build with coverity
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sycl-linux-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ jobs:
-s $GITHUB_WORKSPACE/src -o $GITHUB_WORKSPACE/build \
-DCMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/toolchain \
-t Release \
--ci-defaults ${{ inputs.build_configure_extra_args }} \
--ci-defaults --use-zstd ${{ inputs.build_configure_extra_args }} \
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
-DLLVM_INSTALL_UTILS=ON
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sycl-macos-build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
cd $GITHUB_WORKSPACE/build
python3 $GITHUB_WORKSPACE/src/buildbot/configure.py -w $GITHUB_WORKSPACE \
-s $GITHUB_WORKSPACE/src -o $GITHUB_WORKSPACE/build -t Release \
--ci-defaults $ARGS \
--ci-defaults --use-zstd $ARGS \
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
-DLLVM_INSTALL_UTILS=ON
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sycl-windows-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ jobs:
IF NOT EXIST D:\github\_work\cache MKDIR D:\github\_work\cache
IF NOT EXIST D:\github\_work\cache\${{inputs.build_cache_suffix}} MKDIR D:\github\_work\cache\${{inputs.build_cache_suffix}}
python.exe src/buildbot/configure.py -o build ^
--ci-defaults %ARGS% ^
--ci-defaults --use-zstd %ARGS% ^
"-DCMAKE_C_COMPILER=${{inputs.cxx}}" ^
"-DCMAKE_CXX_COMPILER=${{inputs.cxx}}" ^
"-DCMAKE_INSTALL_PREFIX=%GITHUB_WORKSPACE%\install" ^
Expand Down
2 changes: 1 addition & 1 deletion buildbot/configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def do_configure(args, passthrough_args):

sycl_enable_xpti_tracing = "ON"
xpti_enable_werror = "OFF"
llvm_enable_zstd = "OFF"
llvm_enable_zstd = "ON"
spirv_enable_dis = "OFF"

if sys.platform != "darwin":
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Compression/compression_aot.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
// End-to-End test for testing device image compression in AOT.
// REQUIRES: zstd, opencl-aot, cpu

// XFAIL: target-native_cpu
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/20397

// CPU AOT targets host isa, so we compile on the run system instead.
// RUN: %{run-aux} %clangxx -fsycl -fsycl-targets=spir64_x86_64 %O0 --offload-compress --offload-compression-level=3 %S/Inputs/single_kernel.cpp -o %t_compress.out
// RUN: %{run} %t_compress.out
6 changes: 6 additions & 0 deletions sycl/test-e2e/Compression/compression_separate_compile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@

// REQUIRES: zstd, opencl-aot, cpu, linux

// XFAIL: run-mode && preview-mode
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/20397

// XFAIL: target-native_cpu
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/20397

// CPU AOT targets host isa, so we compile everything on the run system instead.
////////////////////// Compile device images
// RUN: %{run-aux} %clangxx -fsycl -fsycl-targets=spir64_x86_64 -fsycl-host-compiler=clang++ -fsycl-host-compiler-options='-std=c++17 -Wno-attributes -Wno-deprecated-declarations -fPIC -DENABLE_KERNEL1' -DENABLE_KERNEL1 -c %s -o %t_kernel1_aot.o
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/DeviceImageDependencies/dynamic_compress.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@

// REQUIRES: zstd

// XFAIL: (windows && run-mode) || target-native_cpu
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/20397

// DEFINE: %{dynamic_lib_options} = -fsycl %fPIC %shared_lib -fsycl-allow-device-image-dependencies -I %S/Inputs %if windows %{-DMAKE_DLL %}
// DEFINE: %{dynamic_lib_suffix} = %if windows %{dll%} %else %{so%}

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/DeviceLib/bfloat16_conversion_dlopen_test_compress.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

// Check bfloat16 devicelib device image compression.

// XFAIL: target-native_cpu
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/20397

// REQUIRES: linux, zstd
// RUN: rm -rf %t.dir; mkdir -p %t.dir
// RUN: %{build} --offload-compress -DBUILD_LIB -fPIC -shared -o %t.dir/lib%basename_t_compress.so
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/DeviceLib/bfloat16_conversion_test_compress.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

// Check bfloat16 devicelib device image compression.

// XFAIL: target-native_cpu
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/20397

// REQUIRES: linux, zstd
// RUN: rm -rf %t.dir; mkdir -p %t.dir
// RUN: %{build} --offload-compress -DBUILD_LIB -fPIC -shared -o %t.dir/lib%basename_t_compress.so
Expand Down
Loading