[NFC][SYCL][Graph] Avoid unnecessary shared_ptr in duplicateNodes
#19372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes are mostly local to the routine, but I've updated `MIDCache` to use raw `node_impl *` while on it too because `duplicateNodes` accounts for 40% of the places that need updates after the change of the `MIDCache`.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
duplicate-nodes
branch
from
4d0836d to
d42db5e
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Please avoid looking at the first commit in this PR, it's being reviewed separately at #19351. |
maarquitos14
approved these changes
Jul 9, 2025
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
No to both. I'm not adding any new dereferences, only making APIs express pre-existing requirements/guarantees clearer. |
maarquitos14
approved these changes
Jul 9, 2025
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
reble
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are mostly local to the routine, but I've updated
MIDCacheto use rawnode_impl *while on it too becauseduplicateNodesaccounts for 40% of the places that need updates after the change of theMIDCache.