[Benchmark] detect device in benchmarks #19327
Open
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
reviewed
Jul 7, 2025
and adjust kernel execution time for SubmitKernel to ensure similar total execution time for BMG and PVC.
igchor
force-pushed
the
benchmark_detect_device
branch
from
5d8f59b to
ff9e26f
Compare
PatKamin
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and adjust kernel execution time for SubmitKernel
to ensure similar total execution time for BMG
and PVC.
If there is more than one device on the platform,
a warning is printed and the architecture is not set
(which means be will default to some generic benchmark arguments).
This can be extended in future - e.g. we could allow passing a specific
architecture to scripts, similarly as llvm-lit supports
sycl_devices.