[SYCL][E2E] Better handle the Intel Compiler in standalone build (NFC) #18627
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proprietary Intel Compiler (ICX) uses a different installation layout then clang. It puts tools into a bin/compiler subdirectory (to not expose them on the PATH by default). Handle this by not assuming that the compiler is in the same directory as other llvm tools. Ask the compiler for the path to "llvm-config" for the tools directory, using the "-print-prog-name" option. llvm-config was choosen because lit already assumes it is in the tools directory see for example: [llvm/utils/lit/lit/llvm/config.py:285][1] [1]: https://github.com/llvm/llvm-project/blob/9cac4bf485e64f7992f2c01bb9517f6379e58164/llvm/utils/lit/lit/llvm/config.py#L285
|
CI failure is unrelated: #17650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proprietary Intel Compiler (ICX) uses a different installation layout then clang. It puts tools into a bin/compiler subdirectory (to not expose them on the PATH by default). Handle this by not assuming that the compiler is in the same directory as other llvm tools. Ask the compiler for the path to
llvm-configfor the tools directory, using the-print-prog-nameoption.llvm-configwas choosen because lit already assumes it is in the tools directory see for example: llvm/utils/lit/lit/llvm/config.py:285