[UR] Improvements to align CTS and Spec for Device #16746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
d914426 to
73d6fd0
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
73d6fd0 to
09eac51
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
09eac51 to
09ddfe9
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
09ddfe9 to
2c8710b
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
2c8710b to
3b88cac
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
3b88cac to
fcdb51b
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
fcdb51b to
c5c7e20
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
c5c7e20 to
ff4f7dc
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
changed the title
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
approved these changes
Feb 21, 2025
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
ff4f7dc to
2acaec2
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
The failing cuda e2e job is a flaky test being tracked here #17026 |
- Rework urDeviceGetInfoTest to move all enums to their own tests instead of a switch case - oneapi-src/unified-runtime#2290 - Remove the UR/OpenCL Device enum map function - no point maintaining both a switch case and a separate mapping function - Update some spec wording for consistency - Add missing Device info enums to OpenCL adapater - Add new urDevicePartition test for checking UR_DEVICE_INFO_PARENT_DEVICE - Move UUR_RETURN_ON_FATAL_FAILURE and UUR_ASSERT_SUCCESS_OR_UNSUPPORTED to join similar macros in checks.h - Update spec to say info queries that return char[] are null-terminated - Add missing unsupported device enums to HIP adapter - Reverted bindless image types back to size_t - Moved ComponentDevices test to a separate PlatformTest derived fixture - Added new ASSERT_QUERY_RETURNS_VALUE macro as a helper to validate simple numerical GetInfo queries - Added new stringPropertyIsValid helper function to validate string queries
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
2acaec2 to
c518154
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
approved these changes
Feb 21, 2025
|
@intel/dpcpp-nativecpu-reviewers @intel/llvm-reviewers-cuda need reviews for this PR please, it was previously approved pre-UR migration here oneapi-src/unified-runtime#2597 |
frasercrmck
approved these changes
Feb 24, 2025
hvdijk
approved these changes
Feb 24, 2025
14 tasks
kurapov-peter
pushed a commit
to kurapov-peter/llvm
that referenced
this pull request
Mar 5, 2025
Migrated from oneapi-src/unified-runtime#2597 - Rework urDeviceGetInfoTest to move all enums to their own tests instead of a switch case - oneapi-src/unified-runtime#2290 - Remove the UR/OpenCL Device enum map function - no point maintaining both a switch case and a separate mapping function - Update some spec wording for consistency - Add missing Device info enums to OpenCL adapater - Add new urDevicePartition test for checking UR_DEVICE_INFO_PARENT_DEVICE - Move UUR_RETURN_ON_FATAL_FAILURE and UUR_ASSERT_SUCCESS_OR_UNSUPPORTED to join similar macros in checks.h - Update spec to say info queries that return char[] are null-terminated - Add missing unsupported device enums to HIP adapter - Reverted bindless image types back to size_t - Moved ComponentDevices test to a separate PlatformTest derived fixture - Added new ASSERT_QUERY_RETURNS_VALUE macro as a helper to validate simple numerical GetInfo queries - Added new stringPropertyIsValid helper function to validate string queries - Add missing unsupported device enums to HIP adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from oneapi-src/unified-runtime#2597