[UR] Wrap urEventSetCallback when ran through loader #16572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/wrapper
branch
from
e6df430 to
e677d28
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/wrapper
branch
from
e677d28 to
65c5c4e
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
reviewed
Jan 14, 2025
|
Also need to fix the merge conflict. |
RossBrunton
force-pushed
the
ross/wrapper
branch
from
65c5c4e to
8fbf1a2
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
approved these changes
Jan 14, 2025
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
I've created #16630 pointing to the UR commit directly before this to determine if this is the cause of the test failures. If it is, we'll need to revert this to unblock the merge queue. |
Looks like this was probably a runner issue. |
|
@intel/llvm-gatekeepers This should be clear for merging. It had a little hiccup last night with the CI runners, but looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-commit PR for: oneapi-src/unified-runtime#2527