Decouple tbench and dbench #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updated source URL for the dbench package that was introduced in 31dc80f was causing a build error while attempting to install the tbench. In order to fix that, efforts to decouple tbench and dbench are taken. The following changes are introduced in this commit:- 1) Decouple tbench and dbench such that tbench's pkg/ dir and parse file unlink from dbench's 2) Change the source url from 'https://github.com/sahlberg/dbench' to 'https://www.samba.org/ftp/tridge/dbench' 3) Add libtirpc-dev to tbench/depends-dev 4) Add unit tests under spec/stats Signed-off-by: Suneeth D <Suneeth.D@amd.com> Reviewed-by: Srikanth Aithal <saithal@amd.com>
|
thanks for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated source URL for the dbench package that was introduced in 31dc80f was causing a build error while attempting to install the tbench. In order to fix that, efforts to decouple tbench and dbench are taken.
The following changes are introduced in this commit:-