reorganize dirs for distro/adaptation #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli9
reviewed
Mar 7, 2025
lib/install.sh
Outdated
| @@ -45,8 +45,8 @@ adapt_packages() | |||
| { | |||
| local distro_file distro_ver_file | |||
| if [ -z "$PKG_TYPE" ]; then | |||
| distro_ver_file="$LKP_SRC/distro/adaptation/$distro-$_system_version" | |||
| distro_file="$LKP_SRC/distro/adaptation/$distro" | |||
| distro_ver_file="$LKP_SRC/distro/adaptation/$distro/$distro-$_system_version" | |||
There was a problem hiding this comment.
thanks, is it possible to use path like $distro/default and $distro/$_system_version?
There was a problem hiding this comment.
@rli9 sure, had change the path
tzesuinc
force-pushed
the
enhancement-489
branch
from
90b083d to
b858403
Compare
close intel#489 Signed-off-by: Ooi Han Yi han.yi.ooi@intel.com Signed-off-by: Chong Tze Suin tze.suin.chong@intel.com
|
thanks, one thing to bother is due to other PR merged, there's confliction with this PR, need consider to rebase to latest code to resolve confliction. |
tzesuinc
force-pushed
the
enhancement-489
branch
from
a5924ad to
58ecd95
Compare
|
thanks, rebase to latest master and conflict resolved |
rli9
reviewed
Mar 8, 2025
| @@ -45,8 +45,8 @@ adapt_packages() | |||
| { | |||
There was a problem hiding this comment.
thanks, and consider update below code to check Dir.exist in lib/install.rb?
distro_file = "#{LKP_SRC}/distro/adaptation/#{distro}"
return generic_packages unless File.exist? distro_file
rli9
reviewed
Mar 8, 2025
| @@ -45,8 +45,8 @@ adapt_packages() | |||
| { | |||
| local distro_file distro_ver_file | |||
| if [ -z "$PKG_TYPE" ]; then | |||
| distro_ver_file="$LKP_SRC/distro/adaptation/$distro-$_system_version" | |||
| distro_file="$LKP_SRC/distro/adaptation/$distro" | |||
| distro_ver_file="$LKP_SRC/distro/adaptation/$distro/$_system_version" | |||
There was a problem hiding this comment.
thanks, also help update the comment part
# - adaptation by distro version explicitly, via $LKP_SRC/distro/adaptation/$distro-$_system_version
# - adaptation by distro explicitly, via $LKP_SRC/distro/adaptation/$distro
hanyi00i
force-pushed
the
enhancement-489
branch
from
58ecd95 to
66a9024
Compare
|
@rli9 already update the code in |
|
thanks for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #489