Rename libarchive13 to libarchive #499
Conversation
distro/adaptation/opensuse
Outdated
| @@ -50,7 +50,7 @@ libaio-dev: libaio-devel | |||
| libapache2-mpm-itk: apache2 | |||
| libapparmor-dev: libapparmor-devel | |||
| libarchive-dev: libarchive-devel | |||
| libarchive-tools: libarchive13 bsdtar | |||
| libarchive-tools: libarchive bsdtar | |||
There was a problem hiding this comment.
There is a limitation here... Because this change is done in the value of the key-value pair, it will be taken as is. Hence even if the correct mapping of libarchive: libarchive13 is added to this file, it will not be replaced.
There was a problem hiding this comment.
Since the installation script does not recursively search for any other packages in the values to be replaced, this change will break lkp install on opensuse/leap. (OpenSUSE doesn't have libarchive, but has libarchive13 instead)
There was a problem hiding this comment.
Thanks, the right side of mapping doesn't need be changed, since the right side is the actual package on that distro.
There was a problem hiding this comment.
Since the installation script does not recursively search for any other packages in the values to be replaced, this change will break
lkp installonopensuse/leap. (OpenSUSE doesn't havelibarchive, but haslibarchive13instead)
For this, shall we undo this change or should we raise an issue?
There was a problem hiding this comment.
You can undo it and force push a new commit.
There was a problem hiding this comment.
You can undo it and force push a new commit.
Alright, thanks for the clarification 👍
|
thanks, help check the failure on ubuntu/noble in the Checks |
Closes intel#490 Signed-off-by: Wei Shan <wei.shan.lim@intel.com> Signed-off-by: Chiam, Jia Ying <jia.ying.chiam@intel.com> Signed-off-by: Seow, Wen Jie <wen.jie.seow@intel.com>
|
thanks for the patch |
Closes #490