Create test for kernel_match_version function #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli9
reviewed
Mar 6, 2025
lib/kernel_tag.rb
Outdated
| @@ -45,7 +45,7 @@ def kernel_match_version?(kernel_version, expected_kernel_versions) | |||
| kernel_version = KernelTag.new(kernel_version) | |||
|
|
|||
| expected_kernel_versions.all? do |expected_kernel_version| | |||
| match = expected_kernel_version.match(/(?<operator>==|!=|<=|>|>=)?\s*(?<kernel_tag>v[0-9]\.\d+(?:\.\d+)?(?:-rc\d+)?)/) | |||
| match = expected_kernel_version.match(/(?<operator>==|!=|<|<=|>|>=)?\s*(?<kernel_tag>v[0-9]\.\d+(?:\.\d+)?(?:-rc\d+)?)/) | |||
There was a problem hiding this comment.
thanks, looks it's ok not to support <, I can't recall clearly, there's historical reason to avoid confusion so the lkp-tests code doesn't contain any configuration to use <.
rli9
reviewed
Mar 6, 2025
spec/kernel_match_ver_spec.rb
Outdated
| kernel_version = 'v5.8' | ||
| expected_versions = ['>= v5.9'] | ||
| expect(kernel_match_version?(kernel_version, expected_versions)).to eq(false) | ||
| end |
There was a problem hiding this comment.
thanks for the detail description of each test. Is it ok to write multiple tests like below
[
['v5.10', ['>= v5.9'], true],
['v5.11', ['<= v5.10'], false],
...
].each do |test|
it "handles #{test}" do
expect(kernel_match_version?(test[0], test[1])).to eq(test[2])
end
end
There was a problem hiding this comment.
Hi, I have already updated the code based on your review. Thanks for the comment.
|
Thanks, help resolve the failure. Locally, you can run "bundle exec rake rubocop" to check (and add -a option to fix automatically) |
Fix intel#242 Co-authored-by: Ong Yen Yee <yen.yee.ong@intel.com> Signed-off-by: yeetengangIntel <yee.teng.ang@intel.com> Signed-off-by: Ong Yen Yee <yen.yee.ong@intel.com>
|
thanks for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #242