-
Notifications
You must be signed in to change notification settings - Fork 173
Create docker setup for rockylinux:9 #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
distro/adaptation/centos-9
Outdated
@@ -29,6 +29,7 @@ libpfm4: libpfm | |||
libpng12-dev: | |||
libpython2: | |||
libpython3: python3-libs | |||
libunwind: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, what is this change for? Seems libunwind package exists on centos-9
lib/install.sh
Outdated
@@ -148,6 +148,9 @@ map_python_packages() | |||
centos-[9]*) | |||
map_python2_to_python3 | |||
;; | |||
redhat-[9]*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to check detect-system.sh, so we can set _system_name="Rocky", but i'm not sure whether it contains file /etc/os-release or /etc/redhat-release, and what is the content.
If it can be named as Rocky, help add a soft link rockylinux-9 in distro-adaptation to point to centos-9.
lkp-exec/install
Outdated
@@ -388,7 +388,10 @@ distro=$_system_name_lowercase | |||
echo "distro=$distro" | |||
echo "version=$_system_version" | |||
|
|||
[ "$distro" = "centos" ] && enable_centos_source | |||
# Enable source repositories for CentOS and Rocky Linux | |||
if [ "$distro" = "centos" ] || [ "$distro" = "redhat" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I think redhat also need this fix. For this issue, it's better the distro name can be rocky.
8477b72
to
88b0a43
Compare
@rli9 |
Closes intel#415 Co-authored-by: Wei Shan <wei.shan.lim@intel.com> Co-authored-by: Chiam, Jia Ying <jia.ying.chiam@intel.com> Signed-off-by: Seow, Wen Jie <wen.jie.seow@intel.com>
88b0a43
to
de3fef6
Compare
thanks for the patch |
Closes #415