Fix/security recommendations #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security around external command execution, refines looping constructs for image downloads, and updates project ignore rules and CI permissions.
- Replaces vulnerable
execSynccalls withexecFileSyncwrapped intry/catchblocks. - Refactors image‐processing loops to use
for…ofand adds optional chaining for safety. - Updates git/prettier ignore rules and grants necessary permissions for Trivy scans.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| gen/src/generateImages.ts | Switched to execFileSync, added error handling, refactored loops/optionals |
| gen/.gitignore | Added ignore rule for generated GraphQL code |
| .prettierignore | Excluded CHANGELOG.md from formatting |
| .github/workflows/trivy-scan.yml | Granted security-events: write and contents: read permissions |
Comments suppressed due to low confidence (1)
gen/src/generateImages.ts:302
- [nitpick] The variable names
ImageIDandImageUrluse PascalCase; consider usingimageIdandimageUrlto follow camelCase conventions in JavaScript/TypeScript.
for (const [ImageID, ImageUrl] of Object.entries(allImageUrls) as [string, string][]) {
Signed-off-by: Francesa Alfaro, Agustin <agustin.francesa.alfaro@intel.com>
Signed-off-by: Francesa Alfaro, Agustin <agustin.francesa.alfaro@intel.com>
agustinfrancesa
force-pushed
the
fix/security_recommendations
branch
from
7872cf4 to
e7f71d7
Compare
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.