Skip to content

eci: fixing bandit scan error #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

eci: fixing bandit scan error #26

merged 1 commit into from
Jun 19, 2025

Conversation

agustinfrancesa
Copy link
Contributor

No description provided.

Signed-off-by: Francesa Alfaro, Agustin <agustin.francesa.alfaro@intel.com>
@Copilot Copilot AI review requested due to automatic review settings June 19, 2025 14:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a Bandit scan error by updating the CI workflow’s Python setup and checkout steps.

  • Switch Python setup to use the minor version specifier 3.12 instead of a pinned patch.
  • Remove explicit token and persist-credentials settings from the checkout step.
Comments suppressed due to low confidence (3)

.github/workflows/bandit.yml:30

  • [nitpick] For reproducible CI builds, consider pinning to a specific patch version (e.g., '3.12.10') instead of a floating minor version.
        python-version: '3.12'

.github/workflows/bandit.yml:27

  • [nitpick] The step name was generalized from '3.12.10' to '3.12'; ensure this still clearly indicates which interpreter version is in use.
    - name: Set up Python 3.12

.github/workflows/bandit.yml:29

  • Removing the explicit token and persist-credentials: false re-enables default credential persistence; verify this change doesn't expose unintended scopes or allow unauthorized pushes.
      with:

@agustinfrancesa agustinfrancesa merged commit 0284d8e into main Jun 19, 2025
7 checks passed
@agustinfrancesa agustinfrancesa deleted the fix/bandit_scan branch June 19, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant