Skip to content

Security/applying security recommendations #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

agustinfrancesa
Copy link
Contributor

No description provided.

Signed-off-by: Francesa Alfaro, Agustin <agustin.francesa.alfaro@intel.com>
@Copilot Copilot AI review requested due to automatic review settings June 18, 2025 17:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies security recommendations by standardizing dependency installation in various GitHub workflow files.

  • Updates dependency installation commands in semantic-release, check-build, and bandit workflows to rely solely on requirements.txt.
  • Removes individual pip install commands with explicit version pinning to streamline and consolidate dependency management.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/semantic-release.yml Replaces explicit dependency installs with a singular pip install from requirements.txt.
.github/workflows/check-build.yml Simplifies the install dependencies step by removing explicit upgrades and package pinning.
.github/workflows/bandit.yml Updates the dependency installation for Bandit to use requirements.txt in place of explicit installation.
Comments suppressed due to low confidence (2)

.github/workflows/semantic-release.yml:50

  • Ensure that all key dependencies previously installed with explicit version pinning (pip upgrade, setuptools, wheel, python-semantic-release, build) are correctly specified with secured version constraints in requirements.txt to maintain the intended security posture.
      - name: Install dependencies

.github/workflows/bandit.yml:33

  • Confirm that requirements.txt includes a securely pinned version for bandit[sarif] so that the vulnerability scanning remains consistent with the security recommendations.
      shell: bash

@agustinfrancesa agustinfrancesa force-pushed the security/applying-security-recommendations branch 3 times, most recently from 3425e3b to 78daf29 Compare June 18, 2025 17:42
Signed-off-by: Francesa Alfaro, Agustin <agustin.francesa.alfaro@intel.com>
@agustinfrancesa agustinfrancesa force-pushed the security/applying-security-recommendations branch from 78daf29 to 615a0dc Compare June 18, 2025 17:44
@agustinfrancesa agustinfrancesa merged commit 7cf07b8 into main Jun 18, 2025
7 checks passed
@agustinfrancesa agustinfrancesa deleted the security/applying-security-recommendations branch June 18, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant