ci: fix bandit scan #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesa Alfaro, Agustin <agustin.francesa.alfaro@intel.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the CI workflow for the Bandit scan by adjusting credentials handling in the checkout action and renaming the SARIF upload step for clarity.
- Set persist-credentials to false in the checkout action
- Renamed the SARIF upload step from "GitHub Security tab" to "GitHub CodeQL"
Comments suppressed due to low confidence (2)
.github/workflows/bandit.yml:58
- [nitpick] The step name 'Upload SARIF to GitHub CodeQL' might be confusing if it is intended to handle Bandit scan results. Consider renaming the step to more accurately reflect its purpose.
- name: Upload SARIF to GitHub CodeQL
.github/workflows/bandit.yml:40
- Verify that setting persist-credentials to false does not interfere with the subsequent steps that might require authenticated operations.
persist-credentials: false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.