feat(checker): add dcmtk checker #5160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonmarken
requested changes
Jul 15, 2025
There was a problem hiding this comment.
This regex is only going to pick up the pattern for the .rpm, it's not going to pick up debian packages which have been included. I think changing it from dcmtk-([0-9]+.[0-9]+.[0-9]+) to dcmtk(_|-)([0-9]+.[0-9]+.[0-9]+) and it should work.
There was a problem hiding this comment.
The original regex is working perfectly fine on debian and rpm packages (i.e. LONG_TESTS=1 pytest -k dcmtk -v returns PASSED from the 3 test cases)
Moreover, there is not a single occurrence of dcmtk_ in debian package (tested by running zgrep -a dcmtk- ./test/condensed-downloads/dcmtk_3.6.4-2.1_amd64.deb.tar.gz)
Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
ffontaine
force-pushed
the
add-dcmtk-checker
branch
from
d79a066 to
2b49ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.