Skip to content

lib: remove ffi from default features #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

psurply
Copy link
Contributor

@psurply psurply commented Mar 8, 2025

cbindgen is now added as a build dependency only when the "ffi" feature is enabled. This reduces the amount of build dependencies required to build the applications.

@psurply psurply force-pushed the dev/optional_cbindgen branch 2 times, most recently from 173cce9 to e27f3b1 Compare March 8, 2025 12:31
cbindgen is now added as a build dependency only when the "ffi" feature
is enabled. This reduces the amount of build dependencies required to
build the applications.

Signed-off-by: Surply, Pierre <pierre.surply@intel.com>
@psurply psurply force-pushed the dev/optional_cbindgen branch from e27f3b1 to 7695511 Compare March 10, 2025 14:43
@psurply psurply marked this pull request as ready for review March 10, 2025 15:28
@psurply psurply requested a review from jlrivasp March 10, 2025 15:28
Copy link
Contributor

@jlrivasp jlrivasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for the PR, it looks good to me

@jlrivasp jlrivasp merged commit 55df194 into intel:main Mar 12, 2025
5 checks passed
@psurply psurply deleted the dev/optional_cbindgen branch June 12, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants