lib: include die name decode in basic_decode
#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlrivasp
force-pushed
the
dev/basic_decode_diename
branch
2 times, most recently
from
06b757b to
5c114a1
Compare
psurply
requested changes
Apr 15, 2025
jlrivasp
force-pushed
the
dev/basic_decode_diename
branch
from
5c114a1 to
4322780
Compare
psurply
reviewed
Apr 22, 2025
This patch enables an alternative flow inside `decode` function. When the current Crash Log record contains a Header Type 6 (which is the only header at the moment with `die_id` support) and there are no defined decode definitions, the current `basic_decode` function will still try to rename the die name when the header is decoded. This patch also changes the return value of the `decode` function in the Record from a Result to a Node. Signed-off-by: Rivas Paz, Jose L <jose.l.rivas.paz@intel.com>
jlrivasp
force-pushed
the
dev/basic_decode_diename
branch
from
4322780 to
fb68759
Compare
psurply
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables an alternative flow inside
decodeWhen the current Crash Log record contains a Header Type 6 (which is the only header at the moment with
die_idsupport) and there are no defined decode definitions, the currentbasic_decodefunction will still try to rename the die name when the header is decoded.