lib: decode die_id from integer value
#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psurply
reviewed
Mar 26, 2025
This patch includes an optimization when the die id name is parsed. Instead of converting an `u8` value to `String` and then getting the name of the die from the JSON, this patch includes a `Map<u8, String>` The header library can get the die name from this new `Map<u8, String>` and removes the need to convert the original `u8` to `String`. Signed-off-by: Rivas Paz, Jose L <jose.l.rivas.paz@intel.com>
jlrivasp
force-pushed
the
dev/decode_die_int
branch
from
b754c43 to
ca9ceba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes an optimization when the die id name is parsed. Instead of converting an
u8value toStringand then getting the name of the die from the JSON, this patch includes aMap<u8, String>The header library can get the die name from this new
Map<u8, String>and removes the need to convert the originalu8toString.