Skip to content

Commit ffcf2eb

Browse files
David Collinsgregkh
authored andcommitted
spmi: pmic-arb: add missing newline in dev_err format strings
dev_err() format strings should end with '\n'. Several such format strings in the spmi-pmic-arb driver are missing it. Add newlines where needed. Fixes: 02922cc ("spmi: pmic-arb: Register controller for bus instead of arbiter") Signed-off-by: David Collins <quic_collinsd@quicinc.com> Link: https://lore.kernel.org/r/20240703221248.3640490-1-quic_collinsd@quicinc.com Reviewed-by: Bjorn Andersson <andersson@kernel.org> Signed-off-by: Stephen Boyd <sboyd@kernel.org> Link: https://lore.kernel.org/r/20240725164636.3362690-4-sboyd@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent f38ba54 commit ffcf2eb

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/spmi/spmi-pmic-arb.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ static int pmic_arb_fmt_read_cmd(struct spmi_pmic_arb_bus *bus, u8 opc, u8 sid,
398398

399399
*offset = rc;
400400
if (bc >= PMIC_ARB_MAX_TRANS_BYTES) {
401-
dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested",
401+
dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested\n",
402402
PMIC_ARB_MAX_TRANS_BYTES, len);
403403
return -EINVAL;
404404
}
@@ -477,7 +477,7 @@ static int pmic_arb_fmt_write_cmd(struct spmi_pmic_arb_bus *bus, u8 opc,
477477

478478
*offset = rc;
479479
if (bc >= PMIC_ARB_MAX_TRANS_BYTES) {
480-
dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested",
480+
dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested\n",
481481
PMIC_ARB_MAX_TRANS_BYTES, len);
482482
return -EINVAL;
483483
}
@@ -1702,7 +1702,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
17021702

17031703
index = of_property_match_string(node, "reg-names", "cnfg");
17041704
if (index < 0) {
1705-
dev_err(dev, "cnfg reg region missing");
1705+
dev_err(dev, "cnfg reg region missing\n");
17061706
return -EINVAL;
17071707
}
17081708

@@ -1712,7 +1712,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
17121712

17131713
index = of_property_match_string(node, "reg-names", "intr");
17141714
if (index < 0) {
1715-
dev_err(dev, "intr reg region missing");
1715+
dev_err(dev, "intr reg region missing\n");
17161716
return -EINVAL;
17171717
}
17181718

0 commit comments

Comments
 (0)