Skip to content

Commit f38ba54

Browse files
konradybciogregkh
authored andcommitted
spmi: pmic-arb: Pass the correct of_node to irq_domain_add_tree
Currently, irqchips for all of the subnodes (which represent a given bus master) point to the parent wrapper node. This is no bueno, as no interrupts arrive, ever (because nothing references that node). Fix that by passing a reference to the respective master's of_node. Worth noting, this is a NOP for devices with only a single master described. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Link: https://lore.kernel.org/r/20240522-topic-spmi_multi_master_irqfix-v2-1-7ec92a862b9f@linaro.org Reviewed-by: Abel Vesa <abel.vesa@linaro.org> Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Fixes: 02922cc ("spmi: pmic-arb: Register controller for bus instead of arbiter") Cc: stable@vger.kernel.org Signed-off-by: Stephen Boyd <sboyd@kernel.org> Reviewed-by: Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/20240725164636.3362690-3-sboyd@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2c10a20 commit f38ba54

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/spmi/spmi-pmic-arb.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1737,8 +1737,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
17371737

17381738
dev_dbg(&pdev->dev, "adding irq domain for bus %d\n", bus_index);
17391739

1740-
bus->domain = irq_domain_add_tree(dev->of_node,
1741-
&pmic_arb_irq_domain_ops, bus);
1740+
bus->domain = irq_domain_add_tree(node, &pmic_arb_irq_domain_ops, bus);
17421741
if (!bus->domain) {
17431742
dev_err(&pdev->dev, "unable to create irq_domain\n");
17441743
return -ENOMEM;

0 commit comments

Comments
 (0)