Skip to content

Commit bb066fe

Browse files
committed
Merge tag 'pci-v6.14-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci
Pull pci fixes from Bjorn Helgaas: - When saving a device's state, always save the upstream bridge's PM L1 Substates configuration as well because the bridge never saves its own state, and restoring a device needs the state for both ends; this was a regression that caused link and power management errors after suspend/resume (Ilpo Järvinen) - Correct TPH Control Register write, where we wrote the ST Mode where the THP Requester Enable value was intended (Robin Murphy) * tag 'pci-v6.14-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci: PCI/TPH: Restore TPH Requester Enable correctly PCI/ASPM: Fix L1SS saving
2 parents 5b734b4 + 6f64b83 commit bb066fe

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

drivers/pci/pcie/aspm.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,6 @@ void pci_save_aspm_l1ss_state(struct pci_dev *pdev)
108108
pci_read_config_dword(pdev, pdev->l1ss + PCI_L1SS_CTL2, cap++);
109109
pci_read_config_dword(pdev, pdev->l1ss + PCI_L1SS_CTL1, cap++);
110110

111-
if (parent->state_saved)
112-
return;
113-
114111
/*
115112
* Save parent's L1 substate configuration so we have it for
116113
* pci_restore_aspm_l1ss_state(pdev) to restore.

drivers/pci/tph.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ int pcie_tph_set_st_entry(struct pci_dev *pdev, unsigned int index, u16 tag)
360360
return err;
361361
}
362362

363-
set_ctrl_reg_req_en(pdev, pdev->tph_mode);
363+
set_ctrl_reg_req_en(pdev, pdev->tph_req_type);
364364

365365
pci_dbg(pdev, "set steering tag: %s table, index=%d, tag=%#04x\n",
366366
(loc == PCI_TPH_LOC_MSIX) ? "MSI-X" : "ST", index, tag);

0 commit comments

Comments
 (0)