Skip to content

Commit 6f64b83

Browse files
rmurphy-armbjorn-helgaas
authored andcommitted
PCI/TPH: Restore TPH Requester Enable correctly
When we reenable TPH after changing a Steering Tag value, we need the actual TPH Requester Enable value, not the ST Mode (which only happens to work out by chance for non-extended TPH in interrupt vector mode). Link: https://lore.kernel.org/r/13118098116d7bce07aa20b8c52e28c7d1847246.1738759933.git.robin.murphy@arm.com Fixes: d2e8a34 ("PCI/TPH: Add Steering Tag support") Signed-off-by: Robin Murphy <robin.murphy@arm.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Wei Huang <wei.huang2@amd.com>
1 parent 7507eb3 commit 6f64b83

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pci/tph.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ int pcie_tph_set_st_entry(struct pci_dev *pdev, unsigned int index, u16 tag)
360360
return err;
361361
}
362362

363-
set_ctrl_reg_req_en(pdev, pdev->tph_mode);
363+
set_ctrl_reg_req_en(pdev, pdev->tph_req_type);
364364

365365
pci_dbg(pdev, "set steering tag: %s table, index=%d, tag=%#04x\n",
366366
(loc == PCI_TPH_LOC_MSIX) ? "MSI-X" : "ST", index, tag);

0 commit comments

Comments
 (0)