Skip to content

Commit bab8551

Browse files
Karan Tilak Kumarmartinkpetersen
authored andcommitted
scsi: fnic: Remove unnecessary else to fix warning in FDLS FIP
Implement review comments from Martin: Remove unnecessary else from fip.c to fix a warning. Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com> Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com> Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com> Reviewed-by: Arun Easi <aeasi@cisco.com> Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com> Link: https://lore.kernel.org/r/20250106224451.3597-3-kartilak@cisco.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 6cfba11 commit bab8551

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

drivers/scsi/fnic/fip.c

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -154,16 +154,15 @@ void fnic_fcoe_process_vlan_resp(struct fnic *fnic, struct fip_header *fiph)
154154
vlan->state = FIP_VLAN_AVAIL;
155155
list_add_tail(&vlan->list, &fnic->vlan_list);
156156
break;
157-
} else {
158-
FNIC_FIP_DBG(KERN_INFO, fnic->host,
159-
fnic->fnic_num,
160-
"Invalid descriptor type(%x) in VLan response\n",
161-
vlan_desc->fd_desc.fip_dtype);
162-
/*
163-
* Note : received a type=2 descriptor here i.e. FIP
164-
* MAC Address Descriptor
165-
*/
166157
}
158+
FNIC_FIP_DBG(KERN_INFO, fnic->host,
159+
fnic->fnic_num,
160+
"Invalid descriptor type(%x) in VLan response\n",
161+
vlan_desc->fd_desc.fip_dtype);
162+
/*
163+
* Note : received a type=2 descriptor here i.e. FIP
164+
* MAC Address Descriptor
165+
*/
167166
cur_desc += vlan_desc->fd_desc.fip_dlen;
168167
desc_len -= vlan_desc->fd_desc.fip_dlen;
169168
}

0 commit comments

Comments
 (0)