Skip to content

Commit 6cfba11

Browse files
Karan Tilak Kumarmartinkpetersen
authored andcommitted
scsi: fnic: Remove extern definition from .c files
Implement review comments from Martin: Remove extern definition of fnic_fip_queue from .c files Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com> Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com> Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com> Reviewed-by: Arun Easi <aeasi@cisco.com> Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com> Link: https://lore.kernel.org/r/20250106224451.3597-2-kartilak@cisco.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 5b6179d commit 6cfba11

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

drivers/scsi/fnic/fip.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
#include "fip.h"
88
#include <linux/etherdevice.h>
99

10-
extern struct workqueue_struct *fnic_fip_queue;
11-
1210
#define FIP_FNIC_RESET_WAIT_COUNT 15
1311

1412
/**

drivers/scsi/fnic/fip.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,8 @@ void fnic_fcoe_start_flogi(struct fnic *fnic);
131131
void fnic_fcoe_process_cvl(struct fnic *fnic, struct fip_header *fiph);
132132
void fnic_vlan_discovery_timeout(struct fnic *fnic);
133133

134+
extern struct workqueue_struct *fnic_fip_queue;
135+
134136
#ifdef FNIC_DEBUG
135137
static inline void
136138
fnic_debug_dump_fip_frame(struct fnic *fnic, struct ethhdr *eth,

drivers/scsi/fnic/fnic_fcs.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727

2828
#define MAX_RESET_WAIT_COUNT 64
2929

30-
extern struct workqueue_struct *fnic_fip_queue;
3130
struct workqueue_struct *fnic_event_queue;
3231

3332
static uint8_t FCOE_ALL_FCF_MAC[6] = FC_FCOE_FLOGI_MAC;

0 commit comments

Comments
 (0)