Skip to content

Commit 5b6179d

Browse files
Karan Tilak Kumarmartinkpetersen
authored andcommitted
scsi: fnic: Remove unnecessary else and unnecessary break in FDLS
Incorporate review comments from Martin: Remove unnecessary else and unnecessary break to fix warnings in the FDLS code. Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com> Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com> Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com> Reviewed-by: Arun Easi <aeasi@cisco.com> Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com> Link: https://lore.kernel.org/r/20250106224451.3597-1-kartilak@cisco.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 8f22f90 commit 5b6179d

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

drivers/scsi/fnic/fdls_disc.c

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2776,23 +2776,19 @@ fdls_process_tgt_prli_rsp(struct fnic_iport_s *iport,
27762776
/*Retry Plogi again from the timer routine. */
27772777
tport->flags |= FNIC_FDLS_RETRY_FRAME;
27782778
return;
2779-
} else {
2780-
FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
2781-
"PRLI returned ELS_LS_RJT from target: 0x%x",
2782-
tgt_fcid);
2783-
2784-
fdls_tgt_logout(iport, tport);
2785-
fdls_delete_tport(iport, tport);
2786-
return;
27872779
}
2788-
break;
2780+
FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
2781+
"PRLI returned ELS_LS_RJT from target: 0x%x",
2782+
tgt_fcid);
27892783

2784+
fdls_tgt_logout(iport, tport);
2785+
fdls_delete_tport(iport, tport);
2786+
return;
27902787
default:
27912788
atomic64_inc(&iport->iport_stats.tport_prli_misc_rejects);
27922789
FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
27932790
"PRLI not accepted from target: 0x%x", tgt_fcid);
27942791
return;
2795-
break;
27962792
}
27972793

27982794
FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,

0 commit comments

Comments
 (0)