Skip to content

Commit 98a863f

Browse files
Robert Richterdavejiang
authored andcommitted
cxl: Add a dev_dbg() when a decoder was added to a port
Improve debugging by adding and unifying messages whenever a decoder was added to a port. It is especially useful to get the decoder mapping of the involved CXL host bridge or PCI device. This avoids a complex lookup of the decoder/port/device mappings in sysfs. Example log messages: cxl_acpi ACPI0017:00: decoder0.0 added to root0 cxl_acpi ACPI0017:00: decoder0.1 added to root0 ... pci0000:e0: decoder1.0 added to port1 pci0000:e0: decoder1.1 added to port1 ... cxl_mem mem0: decoder5.0 added to endpoint5 cxl_mem mem0: decoder5.1 added to endpoint5 Signed-off-by: Robert Richter <rrichter@amd.com> Reviewed-by: Gregory Price <gourry@gourry.net> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Alison Schofield <alison.schofield@intel.com> Tested-by: Gregory Price <gourry@gourry.net> Acked-by: Dan Williams <dan.j.williams@intel.com> Link: https://patch.msgid.link/20250509150700.2817697-15-rrichter@amd.com Signed-off-by: Dave Jiang <dave.jiang@intel.com>
1 parent d90acdf commit 98a863f

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

drivers/cxl/acpi.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,15 @@ static int __cxl_parse_cfmws(struct acpi_cedt_cfmws *cfmws,
421421
rc = cxl_decoder_add(cxld, target_map);
422422
if (rc)
423423
return rc;
424-
return cxl_root_decoder_autoremove(dev, no_free_ptr(cxlrd));
424+
425+
rc = cxl_root_decoder_autoremove(dev, no_free_ptr(cxlrd));
426+
if (rc)
427+
return rc;
428+
429+
dev_dbg(root_port->dev.parent, "%s added to %s\n",
430+
dev_name(&cxld->dev), dev_name(&root_port->dev));
431+
432+
return 0;
425433
}
426434

427435
static int cxl_parse_cfmws(union acpi_subtable_headers *header, void *arg,

drivers/cxl/core/hdm.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ static int add_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
3434
if (rc)
3535
return rc;
3636

37-
dev_dbg(&cxld->dev, "Added to port %s\n", dev_name(&port->dev));
37+
dev_dbg(port->uport_dev, "%s added to %s\n",
38+
dev_name(&cxld->dev), dev_name(&port->dev));
3839

3940
return 0;
4041
}

0 commit comments

Comments
 (0)