Skip to content

Commit d90acdf

Browse files
Robert Richterdavejiang
authored andcommitted
cxl/region: Add a dev_err() on missing target list entries
Broken target lists are hard to discover as the driver fails at a later initialization stage. Add an error message for this. Example log messages: cxl_mem mem1: failed to find endpoint6:0000:e0:01.3 in target list of decoder1.1 cxl_port endpoint6: failed to register decoder6.0: -6 cxl_port endpoint6: probe: 0 Signed-off-by: Robert Richter <rrichter@amd.com> Reviewed-by: Gregory Price <gourry@gourry.net> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Alison Schofield <alison.schofield@intel.com> Reviewed-by: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com> Tested-by: Gregory Price <gourry@gourry.net> Acked-by: Dan Williams <dan.j.williams@intel.com> Link: https://patch.msgid.link/20250509150700.2817697-14-rrichter@amd.com Signed-off-by: Dave Jiang <dave.jiang@intel.com>
1 parent 9efefa1 commit d90acdf

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

drivers/cxl/core/region.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1809,6 +1809,13 @@ static int find_pos_and_ways(struct cxl_port *port, struct range *range,
18091809
}
18101810
put_device(dev);
18111811

1812+
if (rc)
1813+
dev_err(port->uport_dev,
1814+
"failed to find %s:%s in target list of %s\n",
1815+
dev_name(&port->dev),
1816+
dev_name(port->parent_dport->dport_dev),
1817+
dev_name(&cxlsd->cxld.dev));
1818+
18121819
return rc;
18131820
}
18141821

0 commit comments

Comments
 (0)