Skip to content

Commit 7886a61

Browse files
lclaudioPeter Zijlstra
authored andcommitted
lockdep: suggest the fix for "lockdep bfs error:-1" on print_bfs_bug
When lockdep fails while performing the Breadth-first-search operation due to lack of memory, hint that increasing the value of the config switch LOCKDEP_CIRCULAR_QUEUE_BITS should fix the warning. Preface the scary backtrace with the suggestion: [ 163.849242] Increase LOCKDEP_CIRCULAR_QUEUE_BITS to avoid this warning: [ 163.849248] ------------[ cut here ]------------ [ 163.849250] lockdep bfs error:-1 [ 163.849263] WARNING: CPU: 24 PID: 2454 at kernel/locking/lockdep.c:2091 print_bfs_bug+0x27/0x40 ... Signed-off-by: Luis Claudio R. Goncalves <lgoncalv@redhat.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Boqun Feng <boqun.feng@gmail.com> Reviewed-by: Waiman Long <longman@redhat.com> Link: https://lkml.kernel.org/r/Zqkmy0lS-9Sw0M9j@uudg.org
1 parent dce2a22 commit 7886a61

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

kernel/locking/lockdep.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2067,6 +2067,9 @@ static noinline void print_bfs_bug(int ret)
20672067
/*
20682068
* Breadth-first-search failed, graph got corrupted?
20692069
*/
2070+
if (ret == BFS_EQUEUEFULL)
2071+
pr_warn("Increase LOCKDEP_CIRCULAR_QUEUE_BITS to avoid this warning:\n");
2072+
20702073
WARN(1, "lockdep bfs error:%d\n", ret);
20712074
}
20722075

0 commit comments

Comments
 (0)