Skip to content

Commit dce2a22

Browse files
ubizjakIngo Molnar
authored andcommitted
locking/atomic/x86: Redeclare x86_32 arch_atomic64_{add,sub}() as void
Correct the return type of x86_32 arch_atomic64_add() and arch_atomic64_sub() functions to 'void' and remove redundant return. Signed-off-by: Uros Bizjak <ubizjak@gmail.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Link: https://lore.kernel.org/r/20240605181424.3228-2-ubizjak@gmail.com
1 parent 6e30a7c commit dce2a22

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

arch/x86/include/asm/atomic64_32.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,20 +163,18 @@ static __always_inline s64 arch_atomic64_dec_return(atomic64_t *v)
163163
}
164164
#define arch_atomic64_dec_return arch_atomic64_dec_return
165165

166-
static __always_inline s64 arch_atomic64_add(s64 i, atomic64_t *v)
166+
static __always_inline void arch_atomic64_add(s64 i, atomic64_t *v)
167167
{
168168
__alternative_atomic64(add, add_return,
169169
ASM_OUTPUT2("+A" (i), "+c" (v)),
170170
ASM_NO_INPUT_CLOBBER("memory"));
171-
return i;
172171
}
173172

174-
static __always_inline s64 arch_atomic64_sub(s64 i, atomic64_t *v)
173+
static __always_inline void arch_atomic64_sub(s64 i, atomic64_t *v)
175174
{
176175
__alternative_atomic64(sub, sub_return,
177176
ASM_OUTPUT2("+A" (i), "+c" (v)),
178177
ASM_NO_INPUT_CLOBBER("memory"));
179-
return i;
180178
}
181179

182180
static __always_inline void arch_atomic64_inc(atomic64_t *v)

0 commit comments

Comments
 (0)