Skip to content

Commit 0508316

Browse files
joehattorilag-linaro
authored andcommitted
leds: netxbig: Fix an OF node reference leak in netxbig_leds_get_of_pdata()
netxbig_leds_get_of_pdata() does not release the OF node obtained by of_parse_phandle() when of_find_device_by_node() fails. Add an of_node_put() call to fix the leak. This bug was found by an experimental static analysis tool that I am developing. Fixes: 9af512e ("leds: netxbig: Convert to use GPIO descriptors") Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp> Link: https://lore.kernel.org/r/20241216074923.628509-1-joe@pf.is.s.u-tokyo.ac.jp Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 1c89611 commit 0508316

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/leds/leds-netxbig.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -439,6 +439,7 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
439439
}
440440
gpio_ext_pdev = of_find_device_by_node(gpio_ext_np);
441441
if (!gpio_ext_pdev) {
442+
of_node_put(gpio_ext_np);
442443
dev_err(dev, "Failed to find platform device for gpio-ext\n");
443444
return -ENODEV;
444445
}

0 commit comments

Comments
 (0)