Skip to content

Commit 1c89611

Browse files
elkablolag-linaro
authored andcommitted
turris-omnia-mcu-interface.h: Move macro definitions outside of enums
Move the definitions of enumerator related macros outside of the enumerator definitions. Suggested-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/linux-leds/20241212183357.GK7139@google.com/ Signed-off-by: Marek Behún <kabel@kernel.org> Link: https://lore.kernel.org/r/20241215211323.23364-1-kabel@kernel.org Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 3d69760 commit 1c89611

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

include/linux/turris-omnia-mcu-interface.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,16 +241,18 @@ enum omnia_int_e {
241241

242242
enum omnia_cmd_led_mode_e {
243243
OMNIA_CMD_LED_MODE_LED_MASK = GENMASK(3, 0),
244-
#define OMNIA_CMD_LED_MODE_LED(_l) FIELD_PREP(OMNIA_CMD_LED_MODE_LED_MASK, _l)
245244
OMNIA_CMD_LED_MODE_USER = BIT(4),
246245
};
247246

247+
#define OMNIA_CMD_LED_MODE_LED(_l) FIELD_PREP(OMNIA_CMD_LED_MODE_LED_MASK, _l)
248+
248249
enum omnia_cmd_led_state_e {
249250
OMNIA_CMD_LED_STATE_LED_MASK = GENMASK(3, 0),
250-
#define OMNIA_CMD_LED_STATE_LED(_l) FIELD_PREP(OMNIA_CMD_LED_STATE_LED_MASK, _l)
251251
OMNIA_CMD_LED_STATE_ON = BIT(4),
252252
};
253253

254+
#define OMNIA_CMD_LED_STATE_LED(_l) FIELD_PREP(OMNIA_CMD_LED_STATE_LED_MASK, _l)
255+
254256
enum omnia_cmd_poweroff_e {
255257
OMNIA_CMD_POWER_OFF_POWERON_BUTTON = BIT(0),
256258
OMNIA_CMD_POWER_OFF_MAGIC = 0xdead,

0 commit comments

Comments
 (0)