Skip to content

Commit 0248bfb

Browse files
tobluxDinh Nguyen
authored andcommitted
clk: socfpga: stratix10: Optimize local variables
Since readl() returns a u32, the local variable reg can also have the data type u32. Furthermore, mdiv and refdiv are derived from reg and can also be a u32. Since do_div() casts the divisor to u32 anyway, changing the data type of refdiv to u32 removes the following Coccinelle/coccicheck warning reported by do_div.cocci: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead Compile-tested only. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
1 parent ab49999 commit 0248bfb

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/clk/socfpga/clk-pll-s10.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,9 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hwclk,
8383
unsigned long parent_rate)
8484
{
8585
struct socfpga_pll *socfpgaclk = to_socfpga_clk(hwclk);
86-
unsigned long mdiv;
87-
unsigned long refdiv;
88-
unsigned long reg;
86+
u32 mdiv;
87+
u32 refdiv;
88+
u32 reg;
8989
unsigned long long vco_freq;
9090

9191
/* read VCO1 reg for numerator and denominator */

0 commit comments

Comments
 (0)