Skip to content

Commit ab49999

Browse files
tobluxDinh Nguyen
authored andcommitted
clk: socfpga: clk-pll: Optimize local variables
Since readl() returns a u32, the local variables reg and bypass can also have the data type u32. Furthermore, divf and divq are derived from reg and can also be a u32. Since do_div() casts the divisor to u32 anyway, changing the data type of divq to u32 removes the following Coccinelle/coccicheck warning reported by do_div.cocci: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead Compile-tested only. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
1 parent 0af2f6b commit ab49999

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/clk/socfpga/clk-pll.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hwclk,
3939
unsigned long parent_rate)
4040
{
4141
struct socfpga_pll *socfpgaclk = to_socfpga_clk(hwclk);
42-
unsigned long divf, divq, reg;
42+
u32 divf, divq, reg;
4343
unsigned long long vco_freq;
44-
unsigned long bypass;
44+
u32 bypass;
4545

4646
reg = readl(socfpgaclk->hw.reg);
4747
bypass = readl(clk_mgr_base_addr + CLKMGR_BYPASS);

0 commit comments

Comments
 (0)