Skip to content

Fix ambiguous type comparisons from variants to real types #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2025
Merged

Fix ambiguous type comparisons from variants to real types #392

merged 3 commits into from
Jul 2, 2025

Conversation

cirras
Copy link
Collaborator

@cirras cirras commented Jun 27, 2025

Variant -> Double and Variant -> Extended were being treated as equally good conversions on toolchains where Double and Extended are the same size, such as DCC64.

cirras added 3 commits June 27, 2025 14:42
@cirras
Test DCC64 toolchain in relevant InvocationResolver tests
b1d064d
@cirras
Eliminate always-true condition in isCurrencyCompConflict
099a48b
@cirras
Fix ambiguous type comparisons from variants to real types
334e990 
`Variant` -> `Double` and `Variant` -> `Extended` were being treated as
equally good conversions on toolchains where `Double` and `Extended` are
the same size, such as `DCC64`.
@cirras cirras requested a review from fourls June 27, 2025 05:51
fourls
fourls approved these changes Jul 2, 2025
View reviewed changes
Copy link
Collaborator

@fourls fourls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should probably take a look at changing the default compiler version, it's a little arbitrary to have it fixed at Delphi 11.

@fourls fourls merged commit 7aaba19 into master Jul 2, 2025
4 checks passed
@fourls fourls deleted the variant_to_real_ambiguity branch July 2, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fourls fourls fourls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cirras @fourls