Skip to content

Fix sonar issues #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Fix sonar issues #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8fc37d
Remove unused method parameter
cirras May 14, 2025
0c8b74b
Add missing `@deprecated` Javadoc tag
cirras May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rontend/src/main/java/au/com/integradev/delphi/antlr/ast/visitors/SymbolTableVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,7 @@ private Data createUnitScope(DelphiAst node, Data data) {
FileScope fileScope;

if (name.equals("System")) {
fileScope = new SystemScopeImpl(data.typeFactory);
fileScope = new SystemScopeImpl();
} else if (name.equals("SysInit")) {
fileScope = new SysInitScopeImpl(name, data.systemScope);
} else {
Expand Down
3 changes: 1 addition & 2 deletions delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/scope/SystemScopeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,14 @@
import org.sonar.plugins.communitydelphi.api.symbol.declaration.NameDeclaration;
import org.sonar.plugins.communitydelphi.api.symbol.declaration.TypeNameDeclaration;
import org.sonar.plugins.communitydelphi.api.symbol.scope.SystemScope;
import org.sonar.plugins.communitydelphi.api.type.TypeFactory;

public class SystemScopeImpl extends FileScopeImpl implements SystemScope {
private TypeNameDeclaration objectDeclaration;
private TypeNameDeclaration interfaceDeclaration;
private TypeNameDeclaration varRecDeclaration;
private TypeNameDeclaration classHelperBase;

public SystemScopeImpl(TypeFactory typeFactory) {
public SystemScopeImpl() {
super("System");
}

Expand Down
3 changes: 3 additions & 0 deletions ...i-frontend/src/main/java/org/sonar/plugins/communitydelphi/api/ast/InterfaceGuidNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,8 @@
*/
package org.sonar.plugins.communitydelphi.api.ast;

/**
* @deprecated Interface GUIDs are now parsed as {@link AttributeGroupNode}.
*/
@Deprecated(forRemoval = true)
public interface InterfaceGuidNode extends DelphiNode {}