Improve handling for various intrinsics #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirras
changed the title
fourls
requested changes
May 14, 2025
...-frontend/src/test/java/au/com/integradev/delphi/executor/DelphiSymbolTableExecutorTest.java
Outdated
Show resolved
Hide resolved
cirras
force-pushed
the
intrinsics_round_47
branch
from
5d90f7e to
541e3e5
Compare
Previously it only accepted type references.
cirras
force-pushed
the
intrinsics_round_47
branch
from
541e3e5 to
ef92971
Compare
fourls
requested changes
May 14, 2025
Some intrinsic routines reference types that are declared in the `interface` section of `System`, meaning they shouldn't be injected until the `implementation` section is reached. However, intrinsic types and constants are referenced within the `interface` section and should be injected at the beginning.
Now that we defer the injection of intrinsic routines into `System`, we can resolve public `System` types for intrinsic parameter types and return types.
cirras
force-pushed
the
intrinsics_round_47
branch
from
ef92971 to
c19b721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things.
Improves the way we handle intrinsic routines by:
Systemuntil the end of theinterfacesectionSystemtypes in their parameter lists and return typesAdds support for:
AtomicCmpExchange128GetTypeKindOpenStringtypeImproves signatures of:
IsManagedTypeVarArgStartVarArgGetValueVarArgCopyVarArgEnd