completely removed pynapple #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
oliche
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name says all. I agree that for a processing library it's better to have a more mature library at the foundation, and for analysis it's probably better to have a dedicated environment where pynapple then can be installed. Converting pandas to pynapple works nicely, and I was not making use of pynapples advantages on the more low level analysis in any case.
In the end, the pull request is large: almost all files are changed, but all tests are passing and there are no conflicts. I rather wanted to do it before the restructuring then after. Basically, all
nap.Tsdare nowpd.Seriesand allnap.TsdFramesare nowpd.DataFrames.