go/wasm: Update to Tinygo 0.35.0

[burak-ok]

go/wasm: Update to Tinygo 0.35.0

This uses the newest info from tetratelabs/wazero#2368

[alban]

I am wondering about the UX: does it give a specific error message if trying to run an old version of a gadget with this new version of ig?

[burak-ok]

1. The go:wasmexport there should be no problem. This is just the new directive to export the function.
2. The .WithStartFunctions("_initialize") shouldn't also be a problem AFAIK. I don't know how it behaved in the previous versions of tinygo but this just annotates that the start function of the module is _initialize instead of _start (This is the requirement of the reactor concept)

$ burak/wasm/tinygo.0.35.0 ✓ ➭ go run --exec "sudo -E" ./cmd/ig run trace_exec:v0.37.0
RUNTIME.CONTAINERNAME                 COMM                    PID        TID ARGS                   ERROR
reverent_elbakyan                     sh                    13932      13932 /bin/sh                  
reverent_elbakyan                     date                  13956      13956 /bin/date foo bar             

[eiffel-fl]

1. The go:wasmexport there should be no problem. This is just the new directive to export the function.

   2. The .WithStartFunctions("_initialize") shouldn't also be a problem AFAIK. I don't know how it behaved in the previous versions of tinygo but this just annotates that the start function of the module is _initialize instead of _start (This is the requirement of the reactor concept)

$ burak/wasm/tinygo.0.35.0 ✓ ➭ go run --exec "sudo -E" ./cmd/ig run trace_exec:v0.37.0
RUNTIME.CONTAINERNAME                 COMM                    PID        TID ARGS                   ERROR
reverent_elbakyan                     sh                    13932      13932 /bin/sh                  
reverent_elbakyan                     date                  13956      13956 /bin/date foo bar             

So, for now, tinygo gives us compatibility with both the old and new way of exporting function.
Do they state until when they will keep this?

[burak-ok]

So, for now, tinygo gives us compatibility with both the old and new way of exporting function.
Do they state until when they will keep this?

There is no compatibility AFAIK. If you try to compile old gadgets with 1.25 it will fail (I think at least). The simple test output I showed was running a compiled 1.24 WASM layer with the modifications in our wazero host settings.

So the compiliation might fail or not work. But already compiled gadgets with tinygo 1.24 should still work

[eiffel-fl]

So, for now, tinygo gives us compatibility with both the old and new way of exporting function.
Do they state until when they will keep this?

There is no compatibility AFAIK. If you try to compile old gadgets with 1.25 it will fail (I think at least). The simple test output I showed was running a compiled 1.24 WASM layer with the modifications in our wazero host settings.

What do you mean by 1.24 and 1.25?
So, if an user has an old gadget still using the old syntax, they would be able to run it with a newer ig (using tinygo 0.35), but if they try to compile it again they would get an error message?

So the compiliation might fail or not work. But already compiled gadgets with tinygo 1.24 should still work

[burak-ok]

So, for now, tinygo gives us compatibility with both the old and new way of exporting function.
Do they state until when they will keep this?

There is no compatibility AFAIK. If you try to compile old gadgets with 1.25 it will fail (I think at least). The simple test output I showed was running a compiled 1.24 WASM layer with the modifications in our wazero host settings.

What do you mean by 1.24 and 1.25?

Sorry, my brain was at Go 1.24 :/
I meant tinygo 0.34 and 0.35

So, if an user has an old gadget still using the old syntax, they would be able to run it with a newer ig (using tinygo 0.35), but if they try to compile it again they would get an error message?

I think no compilation error, there might be an error when the gadget runs, that it can't find the exported functions that it expects

[eiffel-fl]

So, for now, tinygo gives us compatibility with both the old and new way of exporting function.
Do they state until when they will keep this?

There is no compatibility AFAIK. If you try to compile old gadgets with 1.25 it will fail (I think at least). The simple test output I showed was running a compiled 1.24 WASM layer with the modifications in our wazero host settings.

What do you mean by 1.24 and 1.25?

Sorry, my brain was at Go 1.24 :/ I meant tinygo 0.34 and 0.35

So, if an user has an old gadget still using the old syntax, they would be able to run it with a newer ig (using tinygo 0.35), but if they try to compile it again they would get an error message?

I think no compilation error, there might be an error when the gadget runs, that it can't find the exported functions that it expects

So, an old gadget could not be used with a newer version of ig using a newer version of tinygo?
If I remember correctly, we wanted to ensure it was possible for an old gadget to be used with a newer version of ig.

[burak-ok]

If I remember correctly, we wanted to ensure it was possible for an old gadget to be used with a newer version of ig.

That would be nice - But we aren't guaranteeing it today even in other PRs. They break left and right

So, an old gadget could not be used with a newer version of ig using a newer version of tinygo?

Every gadget this is already compiled will work. If you try to compile a gadget that didn't receive the changes in this PR, now with the tinygo update from this PR you get the issues. Maybe the following table helps to paint a better picture.

IG Version	Gadget source code prior to this PR	Gadget source code after this PR	Gadget compiled prior to this PR	Gadget compiled after this PR
IG prior this PR	Build no problem - Runs without problem	Build no problem - Doesn't run	Runs without problem	Runs without problem
IG after this PR	Build no problem - Doesn't run	Build no problem - Runs without problem	Runs without problem	Runs without problem

[mauriciovasquezbernal]

LGTM. I'm aware of the IG vs gadget compatibility issues, I'll create an issue soon to go deeper on that, but it doesn't block this issue. Thanks Burak for handling this!