-
-
Notifications
You must be signed in to change notification settings - Fork 26
Remove lookup-refs #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lookup-refs #1395
Conversation
✅ All contributors have signed the CLA |
Unit Tests Summary 1 files 84 suites 1m 14s ⏱️ Results for commit 032ca2c. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit a5c5d39 ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: 032ca2c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nestcolor is required on a lower version than available on CRAN, no sure if it depends on a feature recently released or not. But there is no need for Remotes and lookup-refs can be safely removed now.
Part of https://github.com/insightsengineering/coredev-tasks/issues/609
From now on, we will provide development dependencies in
format, so it's explicitly visible in the DESCRIPTION file and can be handled by
pak::install
,renv::install
andremotes::install
.With development dependencies specified in CJ Pipelines configuration, this connection was hidden, and it was hard to install the package from the main branch (or any other branch) locally from user's machine.