Skip to content

Batch 1 make_afun retirement #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Conversation

Melkiades
Copy link
Contributor

@Melkiades Melkiades commented Feb 3, 2025

Pull Request

Fixes #1381 and #1249 and #1390

@Melkiades Melkiades linked an issue Feb 7, 2025 that may be closed by this pull request
@Melkiades Melkiades linked an issue Feb 17, 2025 that may be closed by this pull request
@Melkiades
Copy link
Contributor Author

@edelarua I got too much into the riskdiff refactoring. I will keep this up until smaller PRs are in! then close it

@Melkiades Melkiades closed this Mar 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
@edelarua
Copy link
Contributor

@Melkiades can this branch be deleted or is it being used elsewhere?

@Melkiades
Copy link
Contributor Author

@Melkiades can this branch be deleted or is it being used elsewhere?

Deleted is fine. Refactoring riskdiff is unnecessary for now. If we have requests to modify its behavior, we can refactor it ;)

@edelarua edelarua deleted the 1381_batch_1_retire_make_afun@main branch April 2, 2025 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R CMD CHECK note Retire make_afun() - Batch 1 export tern:::as_factor_keep_attributes
2 participants