Skip to content

[skip vbump] upversion v0.4.0 #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 28, 2025
Merged

[skip vbump] upversion v0.4.0 #864

merged 4 commits into from
Feb 28, 2025

Conversation

donyunardi
Copy link
Contributor

@donyunardi donyunardi commented Feb 26, 2025

Fixes #842

Summary

  • Update NEWS
  • Update rtables and tern version in DESCRIPTION

Copy link
Contributor

github-actions bot commented Feb 26, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ---------------------------------------
R/tm_a_pca.R                    889     889  0.00%    139-1161
R/tm_a_regression.R             777     777  0.00%    178-1060
R/tm_data_table.R               211     211  0.00%    100-359
R/tm_file_viewer.R              173     173  0.00%    47-255
R/tm_front_page.R               144     133  7.64%    77-247
R/tm_g_association.R            346     346  0.00%    159-580
R/tm_g_bivariate.R              690     426  38.26%   331-818, 859, 970, 987, 1005, 1016-1038
R/tm_g_distribution.R          1119    1119  0.00%    156-1422
R/tm_g_response.R               369     369  0.00%    177-625
R/tm_g_scatterplot.R            731     731  0.00%    260-1095
R/tm_g_scatterplotmatrix.R      296     277  6.42%    198-531, 592, 606
R/tm_missing_data.R            1133    1133  0.00%    124-1434
R/tm_outliers.R                1041    1041  0.00%    163-1355
R/tm_t_crosstable.R             261     261  0.00%    163-472
R/tm_variable_browser.R         832     827  0.60%    89-1078, 1116-1299
R/utils.R                       151     135  10.60%   87-272, 302-338, 350-359, 364, 378-397
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          9165    8850  3.44%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: a59ef75

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Unit Tests Summary

  1 files   22 suites   13m 5s ⏱️
144 tests 107 ✅ 37 💤 0 ❌
474 runs  437 ✅ 37 💤 0 ❌

Results for commit a59ef75.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
examples 💚 $4.94$ $-4.35$ $-1$ $+37$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
examples 💚 $1.73$ $-1.64$ example_add_facet_labels.Rd

Results for commit 2433a5d

♻️ This comment has been updated with latest results.

@donyunardi
Copy link
Contributor Author

Dependency Test - Max failed when installing ggmosaic main branch:
https://github.com/insightsengineering/teal.modules.general/actions/runs/13533557577/job/37820875410#step:9:601

This is because is.waive, which used to be internal, was renamed to is.waiver and exported.
tidyverse/ggplot2#6173

Raised an issue for ggmosaic:
haleyjeppson/ggmosaic#76

Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @donyunardi , left 3 comments

@donyunardi donyunardi requested a review from m7pr February 26, 2025 17:49
@donyunardi
Copy link
Contributor Author

Got a note from win-builder check for R Under development:
https://win-builder.r-project.org/H3O8AWR0H8eG

* checking package dependencies ... ERROR
Package required and available but unsuitable version: 'teal'

See section 'The DESCRIPTION file' in the 'Writing R Extensions'
manual.

I believe this is because the teal 0.16.0 is not yet available for R-devel
image

We might have to wait until it's available before we can submit tmg to CRAN.

…not get stuck

Signed-off-by: cicdguy <26552821+cicdguy@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Feb 26, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@cicdguy
Copy link
Contributor

cicdguy commented Feb 26, 2025

I have read the CLA Document and I hereby sign the CLA

@m7pr m7pr self-assigned this Feb 27, 2025
@donyunardi
Copy link
Contributor Author

Made it to CRAN:
#842 (comment)

@donyunardi donyunardi merged commit 469d2d6 into main Feb 28, 2025
56 checks passed
@donyunardi donyunardi deleted the release-candidate-v0.4.0 branch February 28, 2025 15:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CRAN Release]: 0.4.0
4 participants