Skip to content

Update modules' code for reproducibility #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

llrs-roche
Copy link
Contributor

@llrs-roche llrs-roche commented Jul 23, 2025

Pull Request

Related to https://github.com/insightsengineering/coredev-tasks/issues/646 and insightsengineering/teal.gallery#212

  • {tern} is a dependency but now that the qenv doesn't inherit the environment from the parent.env it must be loaded or functions prefixed to make code fully reproducible in a fresh session (without previous loading anything.
    • append_varlabels
    • summarize_num_patients
    • count_occurrences
    • count_occurrences_by_grade
    • score_occurrences_cont_cols
    • summarize_num_patients
    • summarize_occurrences_by_grade
    • extract_survival_subgroups
    • combine_levels
    • tabulate_survival_subgroups
    • g_forest
    • extract_rsp_subgroups
    • tabulate_rsp_subgroups
    • g_km
    • control_surv_timepoint: Thre is one call within do.call("control_surv_timepoint" that I didn't prefix it because it would fail, we might need to load the package for that module.
    • estimate_multinomial_response
    • estimate_odds_ratio
    • estimate_proportion_diff
    • test_proportion_diff
    • summarize_coxreg
    • fit_logistic
    • default_na_str
    • control_coxreg!
    • control_incidence_rate
    • estimate_incidence_rate
    • estimate_proportions
    • summarize_ancova
  • {rtables} isn't loaded by default: prefixing for:
    • sort_at_path
    • split_fun
    • drop_split_levels
    • add_overall_level
    • trim_levels_to_map
    • keep_split_levels
  • {formatters} is not available on a fresh session for:
    • obj_label
  • Modules tm_t_ancova and tm_t_mmrm depended on the option set on .onLoad for TMC. Instead of removing the call for the default via default_na_str the modules set the default via tern::set_default_na_str
  • Modules tm_t_mmrm, tm_g_barchart_simple, tm_t_g_forest_tte and tm_t_coxreg now use the label instead in the modal on "Show R Code" to be consistent with other modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant