Skip to content

feat(cat-voices): DocumentType list value #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

damian-molinski
Copy link
Contributor

@damian-molinski damian-molinski commented May 16, 2025

Description

Accepts CoseHeaders.type list value and and converts DocumentType to support a list instead of single value.

Based on specs (link)

Related Issue(s)

Resolves #2579

Description of Changes

Converts DocumentType enum into class for supporting multiple values.
Note. note enum so we can supporty partially known types or dynamic definisions.

Breaking changes

FE will start sending type as CborList so backend have to be ready.

Related PRs

BE:
input-output-hk/catalyst-libs#338
input-output-hk/catalyst-libs#356

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski self-assigned this May 16, 2025
@damian-molinski damian-molinski added the dart Pull requests that update Dart code label May 16, 2025
@damian-molinski damian-molinski moved this from New to 🏗 In progress in Catalyst May 16, 2025
Copy link
Contributor

github-actions bot commented May 17, 2025

Test Report | ${\color{lightgreen}Pass: 784/788}$ | ${\color{red}Fail: 0/788}$ |

@damian-molinski damian-molinski changed the title feat(cat-voice): Multi value DocumentType feat(cat-voice): DocumentType list value May 19, 2025
@damian-molinski damian-molinski changed the title feat(cat-voice): DocumentType list value feat(cat-voices): DocumentType list value May 19, 2025
@damian-molinski damian-molinski added do not merge yet PR is not ready to be merged yet review me PR is ready for review labels May 19, 2025
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski damian-molinski moved this from 🏗 In progress to 🛑 Blocked in Catalyst Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code do not merge yet PR is not ready to be merged yet review me PR is ready for review
Projects
Status: 🛑 Blocked
Development

Successfully merging this pull request may close these issues.

Support DocumentType list value
2 participants