-
Notifications
You must be signed in to change notification settings - Fork 9
feat(cat-voices): DocumentType list value #2571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
damian-molinski
wants to merge
12
commits into
main
Choose a base branch
from
feat/multi_type_document
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+670
−212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Test Report | |
dtscalac
reviewed
May 19, 2025
.../packages/internal/catalyst_voices_repositories/lib/src/dto/api/document_index_list_dto.dart
Show resolved
Hide resolved
dtscalac
approved these changes
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dart
Pull requests that update Dart code
do not merge yet
PR is not ready to be merged yet
review me
PR is ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accepts
CoseHeaders.type
list value and and convertsDocumentType
to support a list instead of single value.Based on specs (link)
Related Issue(s)
Resolves #2579
Description of Changes
Converts
DocumentType
enum into class for supporting multiple values.Note. note enum so we can supporty partially known types or dynamic definisions.
Breaking changes
FE will start sending type as
CborList
so backend have to be ready.Related PRs
BE:
input-output-hk/catalyst-libs#338
input-output-hk/catalyst-libs#356
Please confirm the following checks