Skip to content

[IMP] academic: enrollment development #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

lef-adhoc
Copy link
Contributor

No description provided.

@roboadhoc
Copy link

@lef-adhoc lef-adhoc force-pushed the 18.0-t-42285-lef10 branch 11 times, most recently from 52ab7a2 to 0c6435c Compare May 26, 2025 14:38
related="product_id.academic_product_type",
)

@api.depends("academic_product_type")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends explicito mejor..
lo haría dependes solo de "product_id" para que no re-compute frente a un error cambiando setting producto

@jjscarafia jjscarafia force-pushed the 18.0-t-42285-lef10 branch 2 times, most recently from defae34 to 8e161a5 Compare May 28, 2025 18:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements several changes to the academic enrollment module, replacing the study plan concept with sections and streamlining related models and demo data. Key changes include:

  • Removal of the sale order and study plan models and related fields.
  • Refactoring of company, partner, group, level, and section models to support sections instead of study plans.
  • Updates to demo data files and manifest to reflect the new structure.

Reviewed Changes

Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.

Show a summary per file
File Description
academic/models/sale_order.py Removed the SaleOrder model and its compute methods.
academic/models/res_partner.py Removed section_id field and commented out unused methods.
academic/models/res_company.py Replaced study_plan_id with section_ids and removed invoice checks.
academic/models/hr.py Removed study_plan_level_ids field.
academic/models/academic_study_plan.py Removed entirely to drop study plan functionality.
academic/models/academic_section.py Added new fields including sequence, correlative_ids, and level_ids.
academic/models/academic_level.py Removed fields and added a unique SQL constraint on name.
academic/models/academic_group.py Updated fields and method naming, and adjusted domain definitions.
academic/models/init.py Removed references to deleted models.
academic/demo/* Updated demo data (res_users, res_partner, academic_group, etc.) to align with new models.
academic/manifest.py Removed and updated XML and CSV references to reflect removed features.
academic/init.py Removed controllers and post-init hook references.
Comments suppressed due to low confidence (3)

academic/models/academic_level.py:11

  • The new unique_level_name SQL constraint enforces unique academic level names; please verify its impact on existing data and ensure it aligns with business requirements.
_sql_constraints = [
        (
            "unique_level_name",
            "UNIQUE(name)",
            "The level name must be unique.",
        )
    ]

academic/models/res_company.py:16

  • Replacing study_plan_id with section_ids changes the company model structure; ensure that dependent logic, views, and data migration are updated accordingly.
section_ids = fields.Many2many("academic.section", string="Study Plans")

academic/models/academic_group.py:115

  • Renaming open_student_view to open_students may impact calls to this method; confirm that all references have been updated.
def open_students(self):

@lef-adhoc lef-adhoc force-pushed the 18.0-t-42285-lef10 branch from e84530b to a3247ea Compare June 6, 2025 15:06
@lef-adhoc lef-adhoc closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants