18.0 t 42285 lef approach b #257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lef-adhoc
force-pushed
the
18.0-t-42285-lef-approach-b
branch
4 times, most recently
from
cef4ed6 to
b5aedec
Compare
jjscarafia
commented
May 10, 2025
academic/models/crm_lead.py
Outdated
| group_id = fields.Many2one("academic.group") | ||
|
|
||
| def _create_customer(self): | ||
| res = super()._create_customer() |
There was a problem hiding this comment.
un detaller, pero si podés probá hacerlo así:
def _create_customer(self): res = super(CrmLead, self.with_context(default_partner_type="student")._create_customer()
Es basicamente para evitar hacer create y luego write.
si querés mantener el context "from_lead" mandalo, no estoy seguro que otro caso hay.
| from odoo import models | ||
|
|
||
|
|
||
| class Opportunity2Quotation(models.TransientModel): |
There was a problem hiding this comment.
sumado a lo de arriba, si sacamos el if todo esto no es necesario...
hay otros casos donde se cree? tal vez arriba solo lo creamos tipo student si tengo group_id?
igual es un detalle, si no dejalo así..
There was a problem hiding this comment.
Ahí lo dejé que se cree tipo student si tengo group_id y borre el archivo de crm_opportunity_to_quotation
lef-adhoc
force-pushed
the
18.0-t-42285-lef-approach-b
branch
from
b5aedec to
2693d30
Compare
lef-adhoc
force-pushed
the
18.0-t-42285-lef-approach-b
branch
from
2693d30 to
155ce26
Compare
…lude section and subject fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.